Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnx: 1.6.0 -> 1.7.0 #87616

Merged
merged 1 commit into from May 11, 2020
Merged

onnx: 1.6.0 -> 1.7.0 #87616

merged 1 commit into from May 11, 2020

Conversation

acairncross
Copy link
Contributor

Update to most recently released version. Also respect $NIX_BUILD_CORES now that the upstream build has a way to do so.


Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • No reverse dependencies
  • Tested execution of all binary files (usually in ./result/bin/)
  • No executables of interest
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/fxi0ajklnlqqsk2sbjbf8w6ai6vmrw0z-python3.7-onnx-1.6.0          336450424
/nix/store/wls15nm3zgrw19pkw71asz2cp8gxla05-python3.7-onnx-1.7.0          340229832

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 87616 1

2 packages built: - python37Packages.onnx - python38Packages.onnx

@jonringer jonringer merged commit d020db4 into NixOS:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants