Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc10: fix eval due to missing langJit #87637

Merged
merged 1 commit into from May 12, 2020
Merged

gcc10: fix eval due to missing langJit #87637

merged 1 commit into from May 12, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented May 11, 2020

The libgccjit PR was merged after the one introducing gcc10, thus
staging fails to eval because of the missing langJit argument.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @vcunat, @matthewbauer

Currently building gcc10 locally.

@cole-h
gcc10: fix eval due to missing langJit
f7a9303 
The libgccjit PR was merged after the one introducing gcc10, thus
staging fails to eval because of the missing `langJit` argument.
@cole-h cole-h requested a review from matthewbauer as a code owner May 11, 2020 23:59
@cole-h cole-h requested a review from vcunat May 11, 2020 23:59
@matthewbauer
Copy link
Member

Thanks!

@matthewbauer matthewbauer merged commit c890724 into NixOS:staging May 12, 2020
@cole-h cole-h deleted the gcc10 branch May 12, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @matthewbauer