Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tailscale: 0.97-219 -> 0.98-84 #87591

Closed
wants to merge 1 commit into from
Closed

tailscale: 0.97-219 -> 0.98-84 #87591

wants to merge 1 commit into from

Conversation

Br1ght0ne
Copy link
Member

Motivation for this change

https://github.com/tailscale/tailscale/releases/tag/v0.98

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danderson
danderson reviewed May 11, 2020
View reviewed changes
pkgs/servers/tailscale/default.nix
@@ -2,23 +2,23 @@

buildGoModule rec {
pname = "tailscale";
version = "0.97-219";
version = "0.98-84";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package should probably follow Tailscale "stable" releases, not the "often broken" unstable track. The stable version is listed at the bottom of https://pkgs.tailscale.com/stable . This should be 0.98-0, with a checkout rev of 9467acda8407490ce57d553ddc733dca728313dc.

@Lassulus
Copy link
Member

this update seems to be obsolete by now

@Lassulus Lassulus closed this Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danderson danderson danderson left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

@martinbaillie martinbaillie Awaiting requested review from martinbaillie

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @Lassulus @danderson