Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import name/homepage as keyword #30

Merged
merged 1 commit into from May 14, 2020
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 12, 2020

otherwise elasticsearch will performs stemming which removes important
information:

Example:

Name: "nixpkgs-review"
Elasticsearch with 'text' mapping: ["nixpkgs", "review"]

At the moment searching for *nixpkgs-review* will return no results.

otherwise elasticsearch will performs stemming which removes important
information:

Example:

Name: "nixpkgs-review"
Elasticsearch with 'text' mapping: ["nixpkgs", "review"]

Now searching for *nixpkgs-review* will return no results.
@Mic92 Mic92 changed the title import name as keyword import name/homepage as keyword May 12, 2020
@Mic92
Copy link
Member Author

Mic92 commented May 12, 2020

This change might be not required. I found out that match queries, still find the information fine.

Checkout this prototype I built: https://gist.github.com/Mic92/6d153e5d1d21d2ce3bb4da4c03b29082

@garbas
Copy link
Member

garbas commented May 14, 2020

I think this should be keyword too.

Anyway right now are only doing wildcard query on attr_name and option_name. This was done just to reach the parity goal first before focusing on things such as ranking, aggregation, custom tokenizer, ...

Another thing I would like to mention is that if you plan to use elasticsearch from other tools, then I don't guarantee schema will not change. On the contrary we will configure as often as possible to improve the functionality of the frontend.

@garbas garbas merged commit 3816a70 into NixOS:master May 14, 2020
@Mic92 Mic92 deleted the es-improvements branch May 14, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants