New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lxqt.pcmanfm-qt: fix default wallpaper #87623
Conversation
This change sets the wallpaper to one with a NixOS brand. What other distributions have done is make a new branding theme and set it as the default. Maybe we should follow them as soon as the panel/theme issue is fixed. I am not sure about committing this change and would like to see other opinions. |
Yes, setting a branded wallpaper is an opinionated decision. |
ping @worldofpeace @jtojnar |
I am not sure apps should depend on system theme. Is there a way to set the background in a NixOS module rather than pcmanfm? |
I updated the PR to just fix the path instead of using NixOS-artwork. @jtojnar Ok for you? |
Looks like that should work, at least in LxQt. The path is linked: nixpkgs/nixos/modules/services/x11/desktop-managers/lxqt.nix Lines 58 to 59 in 36429a4
And the package is installed unconditionally
nixpkgs/pkgs/desktops/lxqt/default.nix Line 85 in 36429a4
I am not a fan of using this nexus but I guess it is fine until #47173 is resolved. |
7cc50fc
to
8e5d419
Compare
This is currently imho the best (and only without further indirection and hackery) way to have a stable path that always points to the currently active lxqt-themes package. Also fixed a missing slash in this path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 3 commits. Reduce them to just one. Then I think it will be ready for merging.
1cac8f9
to
f805871
Compare
Yes. That was meant for easier review. Should be good for merging now. |
Motivation for this change
#70780
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)