Revert "hydra-queue-runner: Support running in a NixOS container" #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d4b4255. That commit caused builds on the localhost builder to build all dependencies of `preferLocalBuild` derivations as well. It was [suggested](NixOS#749 (comment)) to revert that commit to fix this and I can confirm it indeed fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d4b4255 which caused builds on the localhost builder to build all dependencies of
preferLocalBuildderivations as well. It was suggested by @AmineChikhaoui to revert that commit to fix this and I can confirm it indeed fixes it.@edolstra I expect you to have a better solution for this but I didn't understand the code well enough to know what to revert and what to leave so I just reverted the whole of d4b4255. See this more as a starting point of a conversation on how to properly fix this.