Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arduino: 1.8.9 -> 1.8.12 #87614

Merged
merged 1 commit into from Jun 10, 2020
Merged

arduino: 1.8.9 -> 1.8.12 #87614

merged 1 commit into from Jun 10, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented May 11, 2020 •
edited

Motivation for this change
  • version update
  • added aarch64-linux support
  • reformatted via nixpkgs-fmt
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request May 11, 2020
Closed
10 tasks
@prusnak
Copy link
Member Author

prusnak commented May 11, 2020

@GrahamcOfBorg build arduino teensyduino

@dasj19
Copy link
Contributor

dasj19 commented May 11, 2020 •
edited

@prusnak thanks a lot for picking up where I left off... I would not have made it that far as fast. I am testing at the moment your changes

Edit: I could only test arduino command and it works as expected.
`

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/87614/head:refs/nixpkgs-review/1
remote: Enumerating objects: 707, done.
remote: Counting objects: 100% (707/707), done.
remote: Compressing objects: 100% (20/20), done.
remote: Total 1092 (delta 698), reused 689 (delta 687), pack-reused 385
Receiving objects: 100% (1092/1092), 585.88 KiB | 1.02 MiB/s, done.
Resolving deltas: 100% (805/805), completed with 306 local objects.
From https://github.com/NixOS/nixpkgs
   3d92964d2a4..33a756f431c  master               -> refs/nixpkgs-review/0
 + f9499ce5729...b326d4b5ab1 refs/pull/87614/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /root/.cache/nixpkgs-review/pr-87614/nixpkgs 33a756f431c2bae404d1ebbe2bf457405d813566
Preparing worktree (detached HEAD 33a756f431c)
Updating files: 100% (21687/21687), done.
HEAD is now at 33a756f431c ocamlPackages.lablgtk3: 3.0.beta6 -> 3.1.0
$ nix-env -f /root/.cache/nixpkgs-review/pr-87614/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit b326d4b5ab1316e3b8cd8df79970c84ebfc6cae9
Automatic merge went well; stopped before committing as requested
$ nix-env -f /root/.cache/nixpkgs-review/pr-87614/nixpkgs -qaP --xml --out-path --show-trace --meta
5 packages updated:
arduino (1.8.9 → 1.8.12) arduino-core (1.8.9 → 1.8.12) arduino-core (1.8.9 → 1.8.12) ino teensyduino (1.8.9 → 1.8.12)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /root/.cache/nixpkgs-review/pr-87614/build.nix
[3/4/12 built, 0.0 MiB DL] building avr-gcc-7.3.0-atmel3.6.1-arduino5-x86_64-pc-[3/4/12 built, 0.0 MiB DL] building avr-gcc-7.3.0-atmel3.6.1-arduino5-x86_64-pc-[12 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/87614
4 packages built:
arduino arduino-core ino teensyduino

@prusnak prusnak requested review from bergey and bjornfor May 11, 2020 21:29
@bjornfor bjornfor merged commit 2cb97c3 into NixOS:master Jun 10, 2020
@prusnak prusnak deleted the arduino branch June 10, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergey bergey Awaiting requested review from bergey

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @dasj19 @bjornfor