New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed isnan() to IsReasonable #610
Conversation
src/solvespace.h
Outdated
#ifndef isnan | ||
# define isnan(x) (((x) != (x)) || (x > 1e11) || (x < -1e11)) | ||
#ifndef IsReasonable | ||
# define IsReasonable(x) (((x) != (x)) || (x > 1e11) || (x < -1e11)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole point of renaming would be to get rid of a name collision and all this preprocessor junk. This function should be static inline
inside namespace SolveSpace
, like the WRAP
ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want the WRAP one to be static too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I misremembered that it was already static. It makes zero difference either way. Just make them all the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. unless you want the 3 wrap functions inline too.
Fixes #603.