Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.qiskit: 0.18.2 -> 0.19.1 #87631

Merged
merged 7 commits into from May 12, 2020
Merged

python3Packages.qiskit: 0.18.2 -> 0.19.1 #87631

merged 7 commits into from May 12, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented May 11, 2020 •
edited

Motivation for this change

Bumps metapackage and subcomponents according to https://qiskit.org/documentation/release_notes.html

Also fixes python3Packages.qiskit-aqua breakage on master. Tried to bisect to figure out what caused the breakage but couldn't diagnose. Closest I got was maybe pythonPackages.ipykernel??

Closes #87432.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger marked this pull request as ready for review May 11, 2020 23:16
@ofborg ofborg bot requested a review from pandaman64 May 12, 2020 00:37
@bhipple
Copy link
Contributor

bhipple commented May 12, 2020

Result of nixpkgs-review pr 87631 1

1 package marked as broken and skipped:
- python38Packages.qiskit-ibmq-provider
11 packages built:
- python37Packages.qasm2image
- python37Packages.qiskit
- python37Packages.qiskit-aer
- python37Packages.qiskit-aqua
- python37Packages.qiskit-ibmq-provider
- python37Packages.qiskit-ignis
- python37Packages.qiskit-terra
- python38Packages.qiskit-aer
- python38Packages.qiskit-aqua
- python38Packages.qiskit-ignis
- python38Packages.qiskit-terra

@drewrisinger
Copy link
Contributor Author

drewrisinger commented May 12, 2020 •
edited

Will also update dependency pythonPackages.pylatexenc, just released a new version.

EDIT: python38Packages.qiskit-ibmq-provider is broken b/c upstream python38Packages.aiohttp is disabled on python38. Not sure why it's reported this way.

jonringer
jonringer approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/87631
14 packages built:
python27Packages.pylatexenc python37Packages.pylatexenc python37Packages.qasm2image python37Packages.qiskit python37Packages.qiskit-aer python37Packages.qiskit-aqua python37Packages.qiskit-ibmq-provider python37Packages.qiskit-ignis python37Packages.qiskit-terra python38Packages.pylatexenc python38Packages.qiskit-aer python38Packages.qiskit-aqua python38Packages.qiskit-ignis python38Packages.qiskit-terra

@jonringer jonringer merged commit 25f5b20 into NixOS:master May 12, 2020
@drewrisinger drewrisinger deleted the dr-pr-qiskit-bump branch May 12, 2020 19:11
@drewrisinger
Copy link
Contributor Author

Thanks @jonringer for the quick merge.

@jonringer
Copy link
Contributor

I was busy with personal stuff, you just happened to catch me at a good time! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@pandaman64 pandaman64 Awaiting requested review from pandaman64

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @bhipple @jonringer