pyp: init at 1.0.0 #87605
Closed
pyp: init at 1.0.0 #87605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
May 11, 2020
| @@ -0,0 +1,29 @@ | |||
| { lib, fetchFromGitHub, python3Packages, pkgs }: | |||
There was a problem hiding this comment.
No pkgs but explicit parameters such as jq and bc.
There was a problem hiding this comment.
Done, thanks. I felt a bit silly adding dependencies just because of two tests, but as long as they're not in the actual closure that's okay I suppose.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
JohnAZoidberg
approved these changes
Jun 5, 2022
|
@Kha would you still like to be mentioned as maintainer? |
|
Sure, feel free to add yourself as well |
stale
bot
added
the
2.status: stale
|
@Kha are you still interested in getting this merged? |
stale
bot
removed
the
2.status: stale
|
It looks like this is superseded by #244924 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As featured on Hacker News: run Python one-liners with ease
I took the sources from Github instead of pypi because the latter doesn't include tests, if that makes sense.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)