Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pantheon.wingpanel-indicator-datetime: patch in a lot of fixes #85795

Merged
merged 1 commit into from Apr 22, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

These were rejected upstream, sadly elementary/wingpanel-indicator-datetime#207.

There's been lots of regressions and it's not very usable in NixOS. Luckily though, there's patches that fix all of this, and I've been using them for probably a week now. Once upstream resolves the issues I will drop this downstream patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace merged commit afb08fc into NixOS:master Apr 22, 2020
@worldofpeace worldofpeace deleted the fix-wingpanel-datetime branch April 22, 2020 17:27
@worldofpeace
Copy link
Contributor Author

backported to 20.03 in 8ee460a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant