Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crowbar: init at unstable-2020-04-23 #85797

Merged
merged 1 commit into from May 2, 2020
Merged

crowbar: init at unstable-2020-04-23 #85797

merged 1 commit into from May 2, 2020

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

Bring crowbar to nixpkgs as part of #81418 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Pamplemousse
Copy link
Member Author

Pamplemousse commented Apr 23, 2020 •
edited

As per @jonringer recommendation, I PRed galkan/crowbar#45 to make the package pip installable.
Waiting for their feedback / merge.

@jonringer
Copy link
Contributor

if you want, you can include your PR as a patch, and "re-package" this :). I think that would be acceptable

@Pamplemousse Pamplemousse force-pushed the crowbar branch 2 times, most recently from f239d73 to d5b82e7 Compare April 23, 2020 20:55
@Pamplemousse Pamplemousse changed the title crowbar: init at 4.1 crowbar: init at unstable-2020-04-23 Apr 23, 2020
@Pamplemousse
Copy link
Member Author

@jonringer I am not too sure about what you meant by your comment...

As the PR to upstream has been merged, I updated the one here to unstable-2020-04-23 referencing the latest commit.
However, the "sanity check" triggers a

Traceback (most recent call last):
  File "/nix/store/s2jzaarx2gwbiqgpcxbl7znibafjfrag-crowbar-unstable-2020-04-23/bin/.crowbar-wrapped", line 6, in <module>
    from crowbar import main
ModuleNotFoundError: No module named 'crowbar'

That I can't reproduce. Did I package crowbar wrong?

@Pamplemousse Pamplemousse mentioned this pull request Apr 28, 2020
Merged
jonringer
jonringer reviewed Apr 28, 2020
View reviewed changes
pkgs/tools/security/crowbar/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/crowbar/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/crowbar/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/85797
1 package built:
crowbar

@jonringer jonringer merged commit 98762e7 into NixOS:master May 2, 2020
@Pamplemousse Pamplemousse deleted the crowbar branch August 7, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pamplemousse @jonringer