Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-combined: Remove unused value allSupportedNixpkgs #85685

Merged
merged 1 commit into from Apr 21, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Apr 21, 2020

Motivation for this change

It was made obsolete by commit

2de3caf - nixos/release-combined.nix: List constituents of the 'tested' job by name

see also f996744#r38642487.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @edolstra as commit author, and @grahamc as original author of the value.

Note I haven't tested this at all, only judged by lexicographical scope.

It was made obsolete by commit

    2de3caf -  nixos/release-combined.nix: List constituents of the 'tested' job by name

see also NixOS@f996744#r38642487.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants