Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send download URL via API #29

Open
TrueBrain opened this issue Apr 21, 2020 · 3 comments
Open

Send download URL via API #29

TrueBrain opened this issue Apr 21, 2020 · 3 comments
Labels
enhancement New feature or request prio: high This issue should be fixed when we get the time

Comments

@TrueBrain
Copy link
Member

For new-games, anyone should be able to get the download URLs.
For savegames-only, only the author should be able to get the download URL.

@TrueBrain TrueBrain added enhancement New feature or request prio: high This issue should be fixed when we get the time labels Apr 21, 2020
@nielsmh
Copy link

nielsmh commented Aug 15, 2020

Send download URL via API when... who does what?

@TrueBrain
Copy link
Member Author

All good questions, of which I am pretty sure nobody has an answer yet.

This is a backend ticket, as are all the other tickets in this repo, and as that goes: only adding stuff to the backend is not useful. A PR fixing this should also be accompanied by an PR in https://github.com/OpenTTD/bananas-frontend-web to make use of this. That repo is published at https://bananas.openttd.org/package/base-graphics . Here you can see "available ingame", which should in fact be a download link, supplied by the API. This ticket is about making that possible.

Who-ever implements this should look how the rest of the API is done (hint: swaggerhub has the API specs) and find an appropriate place to add this. I would suggest to talk over the plan with me or @frosch123 before making the real implementation.

Any more information or any specifics, feel free to ask (either here or on IRC). But I think this should be enough guidance to make this happen :) To be clear, this is a relative simple / trivial ticket, about sending data already available down the pipe :)

@frosch123
Copy link
Member

From the API point of view, the download URL should be part of the VersionMinimized structure.

  • Present for all versions tagged as "available for new-games".
  • Present for all versions, if authenticated as author of the package.

However, I think the download URL (read: full md5sum) is currently only known to the bananas-server, not to the bananas-api. So this is probably the hard part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio: high This issue should be fixed when we get the time
Projects
None yet
Development

No branches or pull requests

3 participants