Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace select() with poll() #3522

Merged
merged 1 commit into from Apr 22, 2020
Merged

Replace select() with poll() #3522

merged 1 commit into from Apr 22, 2020

Conversation

HackerFoo
Copy link
Contributor

This change fixes fixes a bug causing nix-build to abort with reached FD_SETSIZE limit when distributing ~400 jobs across 5 build machines.

edolstra
edolstra reviewed Apr 21, 2020
View reviewed changes
src/libstore/build.cc Outdated Show resolved Hide resolved
@HackerFoo HackerFoo requested a review from edolstra April 22, 2020 00:02
@edolstra edolstra merged commit 4a2a45f into NixOS:master Apr 22, 2020
@edolstra
Copy link
Member

Thanks!

@domenkozar domenkozar mentioned this pull request Apr 30, 2020
Open
@HackerFoo HackerFoo mentioned this pull request May 13, 2020
Closed
@ldesgoui ldesgoui mentioned this pull request Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HackerFoo @edolstra