Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/phpfpm: fix erroneous pools example #85708

Merged
merged 1 commit into from Apr 21, 2020

Conversation

tomcur
Copy link
Contributor

@tomcur tomcur commented Apr 21, 2020

Motivation for this change

The example given for services.phpfpm.pools erroneously sets settings as a string, while it should be an attribute set.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Apr 21, 2020

Thanks!

@tomcur tomcur deleted the fix-documentation branch April 21, 2020 20:17
@flokli
Copy link
Contributor

flokli commented Apr 21, 2020

backported to 20.03 in cbb2d62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants