Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trufflehog: 2.0.97 -> 2.1.11 #85730

Merged
merged 2 commits into from May 6, 2020
Merged

trufflehog: 2.0.97 -> 2.1.11 #85730

merged 2 commits into from May 6, 2020

Conversation

kdauler
Copy link
Contributor

@kdauler kdauler commented Apr 21, 2020 •
edited

Motivation for this change

Upgrade Trufflehog to 2.1.11.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc: @kalbasit

@ofborg ofborg bot requested a review from bhipple April 21, 2020 23:51
bhipple
bhipple requested changes May 2, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's change the internal reference to python3Packages explicitly, and squash up the commits.

@kdauler kdauler changed the title Fix/trufflehog 2.1.11 update trufflehog: 2.0.97 -> 2.1.11 May 6, 2020
@ofborg ofborg bot requested a review from bhipple May 6, 2020 00:23
@kdauler kdauler force-pushed the fix/trufflehog-2.1.11-update branch from 2c28266 to 16eac7a Compare May 6, 2020 00:28
@kdauler
Copy link
Contributor Author

kdauler commented May 6, 2020 •
edited

Thanks for your patience with my delay on this @Mic92 and @bhipple 👍

@bhipple
Copy link
Contributor

bhipple commented May 6, 2020

Looks like the pkg got mangled in the squash fixups!

@kdauler
Copy link
Contributor Author

kdauler commented May 6, 2020

Ah yea, and mangled again

@bhipple
Copy link
Contributor

bhipple commented May 6, 2020

LGTM now, would you mind squashing your commits down?

@Mic92 Mic92 merged commit cf0796b into NixOS:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdauler @bhipple @Mic92 @Janik-Haag