Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crosvm: 79.12607.0.0-rc4 -> 81.12871.0.0-rc1 #85731

Merged
merged 2 commits into from Apr 23, 2020
Merged

crosvm: 79.12607.0.0-rc4 -> 81.12871.0.0-rc1 #85731

merged 2 commits into from Apr 23, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Apr 21, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @hyperfekt

@alyssais
chromiumOSPackages.updateScript: fix buildspec url
a6b6933 
"paladin" doesn't seem to be up to date, whereas "full" seems to match
what cros-updates-serving.appspot.com reports is currently being
shipped to Chromebooks.
@alyssais
Copy link
Member Author

OfBorg doesn’t have the aarch64 logs any more so let’s build it again.

@GrahamcOfBorg build crosvm

@alyssais
Copy link
Member Author

alyssais commented Apr 22, 2020 via email

@hyperfekt
Copy link
Contributor

hyperfekt commented Apr 22, 2020 •
edited

The added boot test is really nice. LGTM, builds fine.

@alyssais alyssais merged commit 98b3ac8 into NixOS:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @hyperfekt