add minAge setting to nixos borgbackup options #85696
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToxicFrog
changed the title
bjornfor
approved these changes
May 3, 2020
ToxicFrog
force-pushed
the
borgbackup-minAge
branch
from
6ec1592
to
8a5c4a5
Compare
|
also here (as in #85697), please use a different commit message to add yourself to the maintainers :) |
ToxicFrog
force-pushed
the
borgbackup-minAge
branch
from
8a5c4a5
to
9fa1d88
Compare
Done. |
Lassulus
reviewed
Sep 8, 2020
| @@ -42,6 +42,24 @@ let | |||
| ${cfg.postInit} | |||
| fi | |||
| '' + '' | |||
| # Check if the backup is old enough. | |||
| now=$(date +%s) | |||
There was a problem hiding this comment.
maybe we could add the check only if minAge != 0?
10 tasks
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Not all the systems I back up are online all the time, so I like to run multiple backups per day in the hopes of catching them when they're online, but not bother backing them up if there's already a recent backup. This change adds a
minAgesetting to borgbackup configuration; the backups will be checked with the configured frequency, but skip actually performing the backup if there's one for the same prefix more recent thanminAge.I've been using this feature on my server for about a year now.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)