Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulumi-bin: darwin fix #85801

Merged
merged 2 commits into from Apr 22, 2020
Merged

pulumi-bin: darwin fix #85801

merged 2 commits into from Apr 22, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 22, 2020

Motivation for this change

Closes: #85745

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 22, 2020
@ofborg ofborg bot requested a review from jlesquembre April 22, 2020 18:24
jlesquembre
jlesquembre approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@jlesquembre jlesquembre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on linux, I don't a Mac, and looks good to me.

@veprbl veprbl merged commit e391c83 into NixOS:master Apr 22, 2020
@veprbl veprbl deleted the pr/pulumi_darwin_fix branch April 22, 2020 18:54
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 22, 2020
@veprbl veprbl self-assigned this Apr 22, 2020
veprbl added a commit that referenced this pull request Apr 23, 2020
@veprbl
pulumi-bin: use nativeBuildInputs
c0a4a45 
(cherry picked from commit ba13482)
cc #85801
veprbl added a commit that referenced this pull request Apr 23, 2020
@veprbl
pulumi-bin: fix darwin build
4b30d97 
(cherry picked from commit 712d159)
cc #85801
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 23, 2020
@veprbl veprbl removed their assignment Apr 23, 2020
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@veprbl @stigok
pulumi-bin: use nativeBuildInputs
3754ee7 
(cherry picked from commit ba13482)
cc NixOS#85801
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@veprbl @stigok
pulumi-bin: fix darwin build
6a1282f 
(cherry picked from commit 712d159)
cc NixOS#85801
@veprbl veprbl restored the pr/pulumi_darwin_fix branch December 1, 2020 16:52
@veprbl veprbl deleted the pr/pulumi_darwin_fix branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlesquembre jlesquembre jlesquembre approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulumi fails to install
2 participants
@veprbl @jlesquembre