Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init privacyIDEA packages and modules #85687

Merged
merged 9 commits into from May 13, 2020
Merged

Init privacyIDEA packages and modules #85687

merged 9 commits into from May 13, 2020

Conversation

globin
Copy link
Member

@globin globin commented Apr 21, 2020

Motivation for this change

Packaging of a generic multi factor authentication system (2FA, MFA, OTP Server) and its accompanying LDAP authentication proxy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • N/A macOS
    • N/A other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @elseym @WilliButz @lheckemann @fpletz @Ma27

FRidh
FRidh reviewed Apr 21, 2020
View reviewed changes
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/servers/privacyidea/ldap-proxy.nix Outdated Show resolved Hide resolved
aanderse
aanderse reviewed Apr 21, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things that came to mind. Opinions you're more than welcome to take if you find useful, and ignore if you don't.

nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Show resolved Hide resolved
nixos/modules/services/security/privacyidea.nix Outdated Show resolved Hide resolved
@globin
Copy link
Member Author

globin commented May 8, 2020

I think I've addressed all comments except for the python-modules question above, ping @FRidh ?

@globin
Copy link
Member Author

globin commented May 8, 2020

Updated

@lheckemann lheckemann merged commit db010c5 into NixOS:master May 13, 2020
@lheckemann lheckemann deleted the privacyidea branch May 13, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

@prusnak prusnak prusnak requested changes

@FRidh FRidh FRidh approved these changes

@jonringer jonringer jonringer approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@globin @prusnak @FRidh @jonringer @aanderse @lheckemann