Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding --local-interfaces flag in Agda build #85784

Closed
wants to merge 1 commit into from
Closed

Adding --local-interfaces flag in Agda build #85784

wants to merge 1 commit into from

Conversation

guilhermehas
Copy link
Contributor

@guilhermehas guilhermehas commented Apr 22, 2020 •
edited

This flag is to return the last behavior to generates agdai files inside the directory of the libraries.
This is necessary because nix store is write protected and these files are necessary to run the library without needing to copy it to a different directory.

This link is for the pull request of the Agda compiler changes.
agda/agda#3949

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@guilhermehas
Adding --local-interfaces flag in Agda build
916f8dc 
This flag is to return the last behavior to generates agdai files inside the directory of the libraries.
This is necessary because nix store is write protected and these files are necessary to run the library without needing to copy it to a different directory.
@veprbl
Copy link
Member

veprbl commented May 15, 2020

I believe, this is now addressed by #76653

@Mic92
Copy link
Member

Mic92 commented May 19, 2020

It seems like.

@Mic92 Mic92 closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guilhermehas @veprbl @Mic92 @Janik-Haag