Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link in /etc/os-release #85723

Merged
merged 1 commit into from Apr 21, 2020
Merged

Update link in /etc/os-release #85723

merged 1 commit into from Apr 21, 2020

Conversation

davidak
Copy link
Member

@davidak davidak commented Apr 21, 2020

@garbas garbas merged commit 6a7e056 into NixOS:master Apr 21, 2020
@garbas
Copy link
Member

garbas commented Apr 21, 2020

Should this be also backported to 20.03?

@worldofpeace
Copy link
Contributor

@garbas Probably all stable releases, though it looks like you might be doing a redirect.

@samueldr
Copy link
Member

@worldofpeace would be able to confirm, but I think it should be backported as this is metadata that is in use, and plain wrong.

@davidak
Copy link
Member Author

davidak commented Apr 21, 2020

Should this be also backported to 20.03?

Yes. Is there an easy option to do it with one click or should i create another PR?

@davidak davidak deleted the patch-2 branch April 21, 2020 22:30
@worldofpeace
Copy link
Contributor

Should this be also backported to 20.03?

Yes. Is there an easy option to do it with one click or should i create another PR?

There are backport github actions, but we don't use those "yet". You'll need a new PR.

@worldofpeace
Copy link
Contributor

@davidak davidak restored the patch-2 branch April 21, 2020 22:34
@davidak davidak deleted the patch-2 branch April 21, 2020 22:37
davidak added a commit to davidak/nixpkgs that referenced this pull request Apr 21, 2020
@davidak
Copy link
Member Author

davidak commented Apr 21, 2020

Haha, even so simple documentation is wrong 🤪
As if no one has ever followed it and end up with commiting to their release-20.03 branch instead of feature branch. I have to do everything :(

@worldofpeace
Copy link
Contributor

@davidak Wait you're right 🤣 It should say checkout to a feature branch. I guess it's second nature for a lot.

stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://nixos.org/nixos/support.html is missing yet still referenced in nixpkgs
5 participants