Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

journald service: Increase default rate limit 1000 -> 10000. #85692

Merged
merged 1 commit into from Apr 21, 2020
Merged

journald service: Increase default rate limit 1000 -> 10000. #85692

merged 1 commit into from Apr 21, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Apr 21, 2020

Motivation for this change

Follows the upstream change of this default:

systemd/systemd#8660

I also personally think it is a better default; in fact I had changed it for my systems the same way before I noticed that upstream made this change already in 2018 and NixOS was not updated.

Feels like it'd be cool to have something that notifies us of upstream changed defaults that we have copied into Nix configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 requested a review from flokli April 21, 2020 16:31
@flokli flokli merged commit 91e3358 into NixOS:master Apr 21, 2020
@nh2 nh2 mentioned this pull request Apr 22, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @Mic92 @flokli