Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP lbry: init at 0.44.0 #85769

Closed
wants to merge 1 commit into from
Closed

WIP lbry: init at 0.44.0 #85769

wants to merge 1 commit into from

Conversation

mkg20001
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger reviewed Apr 28, 2020
View reviewed changes
pkgs/applications/video/lbry/default.nix
makeWrapper $out/LBRY/lbry $out/bin/lbry \
--prefix LD_LIBRARY_PATH : ${libpulseaudio}/lib:${pulseaudio}/lib
'';
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's WIP, but needs meta section. Don't forget to follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

@IslandUsurper
Copy link

I converted this change to a default.nix and built it, but running result/bin/lbry gave this output

Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"
Trace/breakpoint trap (core dumped)

@IslandUsurper IslandUsurper mentioned this pull request Aug 1, 2020
Closed
@mkg20001
Copy link
Member Author

mkg20001 commented Aug 2, 2020

Exactly where I gave up... Didn't have the time so far to focus more on this

@IslandUsurper
Copy link

IslandUsurper commented Aug 3, 2020 •
edited

I've gotten further now. (Gist) I followed the example of Slack in nixpkgs, another Electron app built from a .deb, and the app runs, but not well. For some reason it won't open the wallet headers I already had on my system before I switched to NixOS (which is why I'm keen on getting it in nixpkgs).

@IslandUsurper IslandUsurper mentioned this pull request Aug 26, 2020
Closed
10 tasks
@ryantm ryantm marked this pull request as draft October 10, 2020 03:26
@SuperSandro2000
Copy link
Member

Replaced by #96368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkg20001 @IslandUsurper @SuperSandro2000 @drewrisinger