dosbox-staging: init at v0.75.0 #85744
Conversation
The official website wasn't ready until recently. Co-Authored-By: Louis Bettens <lourkeur@users.noreply.github.com>
JoshuaFern
changed the title
|
Happy release day! The changes between versions is minimal. I think this is ready to merge @aanderse |
|
No regression re: GNOME3 experience 👍 |
| preConfigure = "./autogen.sh"; | ||
|
|
||
| preBuild = '' | ||
| buildFlagsArray=( "CXXFLAGS=-O3 -DNDEBUG" ) |
There was a problem hiding this comment.
Are these actually required? If so, wouldn't something like buildFlags = [ "CXXFLAGS=-03" ]; be better?
There was a problem hiding this comment.
I believe -DNDEBUG is required, maybe @dreamer could elaborate why.
There was a problem hiding this comment.
I had trouble getting buildFlags to play nice with -DNDEBUG so I used CXXFLAGS = "-O3 -DNDEBUG"; instead after I saw a few other packages using this.
There was a problem hiding this comment.
Both are required for release builds (in fact more compilation flags might be beneficial, with different sets per architecture, but simple -O3 -DNDEBUG is good enough across the board and good enough for the first release :)
Explanation:
NDEBUGis standard POSIX-defined flag, that should be used for all C/C++ projects providing release binaries. GNU doc.-O3- the codebase is written in a way, that's very heavily affected by compiler optimizations; this level enables some crucial ones (like loop unrolling, switch/loop unrolling, vectorization, predictive commoning, etc)
One more note: dosbox-staging is mixed C/C++ codebase, so please use:
CFLAGS=-O3 -DNDEBUG
CXXFLAGS=-O3 -DNDEBUG
There was a problem hiding this comment.
@JoshuaFern I should have been more specific... I'm wondering if these values are needed in the derivation because maybe they are already implied by our build system. I don't know and this area is certainly a weak point in my knowledge. You could dig into our docs, builder code, or ping one of many people who know off the top of their head. Sorry I'm not being more help 😞
There was a problem hiding this comment.
Running the build and searching through the log I'm not seeing -DNDEBUG and it's using -02 by default. I believe we need these manually defined.
Sorry I'm not being more help
You have good suggestions, thanks! :)
|
@JoshuaFern good stuff. At this point I recommend you get an |
|
This PR has gone a bit stale, I'm closing it for now. |
Motivation for this change
dosbox-staging attempts to modernize the DOSBox codebase by using current development practices and tools, fixing issues, and adding features that better support today's systems.
If you review and install this package, please check that your icon/desktop file is working correctly on your DE of choice.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)