Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cloudflare: init at 2.6.5 #85773

Merged
merged 2 commits into from Apr 28, 2020
Merged

pythonPackages.cloudflare: init at 2.6.5 #85773

merged 2 commits into from Apr 28, 2020

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Apr 22, 2020 •
edited

Motivation for this change

Using this for my own development and wanted to push it upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.cloudflare python3Packages.cloudflare python2Packages.auth0-python python3Packages.auth0-python

@CloudArtAdmins
Copy link
Contributor

This worked for me, the bin showed accurate version.

@costrouc
Copy link
Member Author

costrouc commented Apr 23, 2020 •
edited

Requested changes made.

@GrahamcOfBorg build python2Packages.cloudflare python3Packages.cloudflare python2Packages.auth0-python python3Packages.auth0-python

@costrouc
Copy link
Member Author

^ what would have caused this to fail? I only put the urls in quotes since

@jonringer
Copy link
Contributor

borg was broken on master, rebase the PR and it should fix it:

git pull -r origin/master
git push .. .. --force

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.cloudflare python3Packages.cloudflare python2Packages.auth0-python python3Packages.auth0-python

@costrouc
Copy link
Member Author

Ready for merge

jonringer
jonringer approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 85773 1

6 packages built:
- python27Packages.auth0-python
- python27Packages.cloudflare
- python37Packages.auth0-python
- python37Packages.cloudflare
- python38Packages.auth0-python
- python38Packages.cloudflare

@jonringer jonringer merged commit 27c7e7d into NixOS:master Apr 28, 2020
@costrouc costrouc deleted the python-cloudflare-init branch April 28, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @CloudArtAdmins @jonringer