Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: python3Packages.bokeh: 1.4.0 -> 2.0.1 #85758

Closed
wants to merge 1 commit into from
Closed

WIP: python3Packages.bokeh: 1.4.0 -> 2.0.1 #85758

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Apr 22, 2020

Tests still don't function. Somehow fixtures cannot be found causing massive failures...

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
WIP: python3Packages.bokeh: 1.4.0 -> 2.0.1
2a0e142 
Tests still don't function. Somehow fixtures cannot be found causing massive failures...
@FRidh FRidh requested a review from orivej-nixos April 22, 2020 10:04
@FRidh FRidh requested a review from jonringer as a code owner April 22, 2020 10:04
@FRidh
Copy link
Member Author

FRidh commented Apr 22, 2020

note 2.0.2 has been tagged

jonringer
jonringer reviewed Apr 22, 2020
View reviewed changes
pkgs/development/python-modules/bokeh/default.nix
]
++ lib.optionals ( isPy27 ) [
futures
];

checkPhase = ''
${python.interpreter} -m unittest discover -s bokeh/tests
pytest tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see you declared disabledTests did you mean to use pytestCheckHook?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I was initially but since I needed to debug more that wasn't helpful

FRidh added a commit that referenced this pull request Apr 24, 2020
@FRidh
python3Packages.panel: 0.7.0 -> 0.8.3
2058aeb 
A newer version is available but requires bokeh >= 2.
See #85758 for WIP bokeh PR.
@FRidh
Copy link
Member Author

FRidh commented Jun 4, 2020

pushed 2.0.2 in 491b4da (note incorrect commit message)

@FRidh FRidh closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@orivej-nixos orivej-nixos Awaiting requested review from orivej-nixos

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @jonringer