Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memtest86plus: 5.0.1-coreboot-002 -> 5.31b #85790

Closed
wants to merge 1 commit into from
Closed

memtest86plus: 5.0.1-coreboot-002 -> 5.31b #85790

wants to merge 1 commit into from

Conversation

evils
Copy link
Member

@evils evils commented Apr 22, 2020 •
edited

CAUTION, beta release

This build is not ready for production yet, because it lacks some feedbacks from beta-testers.
despite this, i'd still like to see this merged as i have not found anyone for whom the current package works on bare metal

Motivation for this change

coreboot's v002 is broken for me, a significantly newer version than their master branch is available.

Things done

switched source from coreboot to memtest.org
(partially?) fixed checkPhase
set the description to the project's own
added myself as a maintainer as there currently isn't one set

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notes
  • I'd love to see a nixos test for this :D

@ajs124
Copy link
Member

ajs124 commented Apr 22, 2020

How is the current version broken? Testing it in a vm like this:

nix-build nixos --arg configuration '{ boot.loader.grub.memtest86.enable = true; }' -A vmWithBootLoader
./result/bin/run-nixos-vm

works for me.

@evils
Copy link
Member Author

evils commented Apr 22, 2020

coreboot's v002 spews an endless slew of errors, on both my thinkpad t410 and a friend's desktop
i'm fairly confident these are not real errors,
they go away when switching to the latest version from memtest.org or coreboot.org
and these devices otherwise worked fine, so it seems unlikely there's that many faults
@ajs124's VM test works for me though

@seghers
Copy link

seghers commented Jun 26, 2020

Current memtest (memtest86plus: 5.0.1-coreboot-002) gives me also errors on 2 tested bare metal systems:

  • Thinkpad T540p
  • Supermicro X9DRi-F

@ryantm
Copy link
Member

ryantm commented Nov 24, 2020

I think we should wait until it is out of beta.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 18, 2021 18:45
SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/tools/misc/memtest86+/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/memtest86+/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 85790 run on x86_64-linux 1

1 package built:
  • memtest86plus

@expipiplus1
Copy link
Contributor

FWIW this works on my hardware where 5.0.1 freezes, thanks @evils!

@stale
Copy link

stale bot commented Oct 30, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2021
@expipiplus1
Copy link
Contributor

still important, @stalebot.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 11, 2021
@evils
Copy link
Member Author

evils commented Apr 7, 2022

closing in favour of #167680
5.31b < pcmemtest < 6.0

@evils evils closed this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@evils @ajs124 @seghers @ryantm @SuperSandro2000 @expipiplus1