nodePackages: switch to 12 #85764
nodePackages: switch to 12 #85764
Conversation
|
nodejs 10 is about to sunset and nodejs 12 is taking over: https://nodejs.org/en/about/releases/ |
|
IIUC there is no need to use different node-packages-vXX.nix for each node version. could you please give the following a try? --- c/pkgs/development/node-packages/generate.sh
+++ i/pkgs/development/node-packages/generate.sh
@@ -6,6 +6,4 @@ node2nix=$(nix-build ../../.. --no-out-link -A nodePackages.node2nix)
cd ${DIR}
rm -f ./node-env.nix
-for version in 10 12 13; do
- "${node2nix}/bin/node2nix" --nodejs-$version -i node-packages-v$version.json -o node-packages-v$version.nix -c composition-v$version.nix
-done
+"${node2nix}/bin/node2nix" -i node-packages.json -o node-packages.nix -c composition.nixso we could use: nodePackages_12_x = dontRecurseIntoAttrs (callPackage ../development/node-packages {
nodejs = pkgs.nodejs-12_x;
}); |
|
@svanderburg how do you feel about re-using the packages? Is this safe to do? Right now node12 is handled the same way as node13: https://github.com/svanderburg/node2nix/blob/master/bin/node2nix.js#L135 |
|
I was interested if any package was restricted to a max.
|
| @@ -4779,7 +4779,7 @@ in | |||
|
|
|||
| nixnote2 = libsForQt5.callPackage ../applications/misc/nixnote2 { }; | |||
|
|
|||
| nodejs = hiPrio nodejs-10_x; | |||
| nodejs = hiPrio nodejs-12_x; | |||
|
|
|||
| nodejs-slim = nodejs-slim-10_x; | |||
There was a problem hiding this comment.
I think we should also change nodejs-slim?
| @@ -6,6 +6,6 @@ node2nix=$(nix-build ../../.. --no-out-link -A nodePackages.node2nix) | |||
|
|
|||
| cd ${DIR} | |||
| rm -f ./node-env.nix | |||
| for version in 10 12 13; do | |||
| for version in 12 13; do | |||
There was a problem hiding this comment.
Hm, maybe we could drop nodejs-13 and use nodejs-14 instead? (That is: we're keeping LTS and latest stable).
| for version in 12 13; do | |
| for version in 12 14; do |
Or even better have just one set of node_packages as suggest by @marsam above
|
Maybe someone else can take this over. |
|
I am interested in working on it. If no one else is working on it, i will create a new PR based on this one, including the suggested changes, until upcoming weekend. |
I would review it, if you cc me. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)