Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shopify-themekit: init at 1.0.3 #85688

Merged
merged 1 commit into from Apr 22, 2020
Merged

shopify-themekit: init at 1.0.3 #85688

merged 1 commit into from Apr 22, 2020

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Apr 21, 2020

Motivation for this change

Package command line tool for shopify themes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@1000101
Copy link
Member Author

1000101 commented Apr 21, 2020

@GrahamcOfBorg build shopify-themekit

@mmahut mmahut merged commit d5c1303 into NixOS:master Apr 22, 2020
@1000101 1000101 deleted the shopify_themekit branch April 22, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants