Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dropbox: new module #85699

Closed
wants to merge 1 commit into from
Closed

nixos/dropbox: new module #85699

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 21, 2020

Motivation for this change

Add a module for the dropbox service.

See also https://nixos.wiki/wiki/Dropbox

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo requested a review from infinisil as a code owner April 21, 2020 17:18
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/using-dropbox-on-nixos/387/24

@peterhoeg
Copy link
Member

Since we have an open source alternative, maestral, we should make the package used configurable to support both.

@romildo
Copy link
Contributor Author

romildo commented Apr 22, 2020

Since we have an open source alternative, maestral, we should make the package used configurable to support both.

The systemd units would be different for dropbox and for maestral. Maybe a solution is to let the package install the unit, and the module would use it.

@peterhoeg
Copy link
Member

peterhoeg commented Apr 22, 2020 via email

after = [ "xembedsniproxy.service" ];
wants = [ "xembedsniproxy.service" ];
environment = {
QT_PLUGIN_PATH = "/run/current-system/sw/" + pkgs.qt5.qtbase.qtPluginPrefix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment why this is needed? Should not the app be wrapped with wrapQtAppsHook?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dropbox downloads its own binaries at runtime.


systemd.user.services.dropbox = {
description = "Dropbox daemon";
after = [ "xembedsniproxy.service" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterhoeg can you comment on the dependency on xembedsniproxy.service? What is its purpose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be the only way to have dropbox show a trayicon - I have no idea if that is still the case as I'm not using dropbox any more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some kind of plasma thing: https://github.com/davidedmundson/xembed-sni-proxy

QT_PLUGIN_PATH = "/run/current-system/sw/" + pkgs.qt5.qtbase.qtPluginPrefix;
QML2_IMPORT_PATH = "/run/current-system/sw/" + pkgs.qt5.qtbase.qtQmlPrefix;
};
serviceConfig = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream service file would be indeed nicer. How do other distros handle this?

@peterhoeg
Copy link
Member

peterhoeg commented Apr 22, 2020 via email

@SRGOM
Copy link
Member

SRGOM commented Apr 22, 2020

@peterhoeg Peter, might I take your time/attention to get #77734 (re) reviewed too? Along the same lines (and while I don't know the policy regarding what belongs in Nixos and what doesn't, and the policy changes related to that, I feel that dropbox and OneDrive would be under the same policy...)

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@romildo romildo closed this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants