New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/dropbox: new module #85699
nixos/dropbox: new module #85699
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Since we have an open source alternative, |
The systemd units would be different for |
The systemd units would be different for dropbox and for maestral.
Sure.
Maybe a solution is to let the package install the unit, and the module
would use it.
That's definitely an option, but you would still have to augment it if you want to activate it globally so you still need to handle the different units.
|
after = [ "xembedsniproxy.service" ]; | ||
wants = [ "xembedsniproxy.service" ]; | ||
environment = { | ||
QT_PLUGIN_PATH = "/run/current-system/sw/" + pkgs.qt5.qtbase.qtPluginPrefix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment why this is needed? Should not the app be wrapped with wrapQtAppsHook
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think dropbox downloads its own binaries at runtime.
|
||
systemd.user.services.dropbox = { | ||
description = "Dropbox daemon"; | ||
after = [ "xembedsniproxy.service" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterhoeg can you comment on the dependency on xembedsniproxy.service
? What is its purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It used to be the only way to have dropbox show a trayicon - I have no idea if that is still the case as I'm not using dropbox any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some kind of plasma thing: https://github.com/davidedmundson/xembed-sni-proxy
QT_PLUGIN_PATH = "/run/current-system/sw/" + pkgs.qt5.qtbase.qtPluginPrefix; | ||
QML2_IMPORT_PATH = "/run/current-system/sw/" + pkgs.qt5.qtbase.qtQmlPrefix; | ||
}; | ||
serviceConfig = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream service file would be indeed nicer. How do other distros handle this?
Upstream service file would be indeed nicer. How do other distros handle
this?
Neither dropbox nor maestral upstream carry systemd units.
In maestral's case it's been on my list for a long time but until that happens, we'll need to handle it here.
|
@peterhoeg Peter, might I take your time/attention to get #77734 (re) reviewed too? Along the same lines (and while I don't know the policy regarding what belongs in Nixos and what doesn't, and the policy changes related to that, I feel that dropbox and OneDrive would be under the same policy...) |
I marked this as stale due to inactivity. → More info |
Motivation for this change
Add a module for the dropbox service.
See also https://nixos.wiki/wiki/Dropbox
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)