Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh-chat: init at 1.9 #85701

Merged
merged 1 commit into from Jul 7, 2020
Merged

ssh-chat: init at 1.9 #85701

merged 1 commit into from Jul 7, 2020

Conversation

luc65r
Copy link
Contributor

@luc65r luc65r commented Apr 21, 2020 •
edited

Motivation for this change

Add ssh-chat for #85447

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CloudArtAdmins
Copy link
Contributor

This seems to work for me.

@Br1ght0ne
Copy link
Member

Result of nixpkgs-review pr 85701 1

1 package built:
- ssh-chat

@ehmry
Copy link
Contributor

ehmry commented Jul 7, 2020

Good to merge?

@ehmry ehmry merged commit af0d1f9 into NixOS:master Jul 7, 2020
@luc65r luc65r deleted the pkg/ssh-chat branch July 7, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luc65r @CloudArtAdmins @Br1ght0ne @ehmry