Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p7zip: Make unfree features (rar support) optional #85782

Merged
merged 1 commit into from Apr 22, 2020
Merged

p7zip: Make unfree features (rar support) optional #85782

merged 1 commit into from Apr 22, 2020

Conversation

adisbladis
Copy link
Member

Motivation for this change

Follow up for #85780 in case anyone is actually depending on the unfree features.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

Is this worth it? We have two free programs packaged that do exactly this. If somebody really needs this specific program to do it, it would be reasonable to request the change, but I’m not sure we need to anticipate it…

@alyssais alyssais requested a review from emilazy April 22, 2020 15:13
alyssais
alyssais approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on IRC. I’m happy with this. It should be backported along with #85780.

@adisbladis adisbladis merged commit 4340329 into NixOS:master Apr 22, 2020
@emilazy emilazy mentioned this pull request Oct 31, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

@emilazy emilazy Awaiting requested review from emilazy

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @alyssais