Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bd8e084703a0
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 95b9c99f6d09
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 22, 2020

  1. pythonPackages.namedlist: unmark broken, mark disabled for Python 3.8 

    https://nix-cache.s3.amazonaws.com/log/a4mdvyjbsy157i1v97rg6avp5a8inm0g-python3.8-namedlist-1.7.drv
    @ivan
    ivan committed Apr 22, 2020
    Copy the full SHA
    3f7a5cb View commit details

  2. pythonPackages.ludios_wpull: unmark broken, mark disabled for Python 3.8 

    ludios_wpull depends on namedlist, which currently has failing tests
on Python 3.8.
    @ivan
    ivan committed Apr 22, 2020
    Copy the full SHA
    dd2570d View commit details

  3. Merge pull request #85533 from ivan/mark-some-unbroken 

    [20.03] pythonPackages.{namedlist, ludios_wpull}: mark broken only on Python 3.8
    @worldofpeace
    worldofpeace authored Apr 22, 2020
    Copy the full SHA
    95b9c99 View commit details
Showing with 5 additions and 3 deletions.
  1. +2 −2 pkgs/development/python-modules/ludios_wpull/default.nix
  2. +3 −1 pkgs/development/python-modules/namedlist/default.nix
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/ludios_wpull/default.nix
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@
, buildPythonPackage
, fetchFromGitHub
, isPy3k
, isPy38
, chardet
, dnspython
, html5-parser
@@ -16,7 +17,7 @@ buildPythonPackage rec {
pname = "ludios_wpull";
version = "3.0.7";

disabled = !isPy3k;
disabled = !isPy3k || isPy38;

src = fetchFromGitHub {
rev = version;
@@ -35,6 +36,5 @@ buildPythonPackage rec {
homepage = https://github.com/ludios/wpull;
license = lib.licenses.gpl3;
maintainers = with lib.maintainers; [ ivan ];
broken = true;
};
}
4 changes: 3 additions & 1 deletion pkgs/development/python-modules/namedlist/default.nix
View file
Original file line number Diff line number Diff line change
@@ -2,12 +2,15 @@
, buildPythonPackage
, fetchPypi
, pytest
, isPy38
}:

buildPythonPackage rec {
pname = "namedlist";
version = "1.7";

disabled = isPy38;

src = fetchPypi {
inherit pname version;
sha256 = "11n9c4a5ak9971awkf1g92m6mcmiprhrw98ik2cmjsqxmz73j2qr";
@@ -29,6 +32,5 @@ buildPythonPackage rec {
homepage = https://bitbucket.org/ericvsmith/namedlist;
license = lib.licenses.asl20;
maintainers = with lib.maintainers; [ ivan ];
broken = true;
};
}