Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 50ba3f7ad80e
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a63762ace8a6
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 27, 2019

  1. python3Packages.pytest4: deterministic bytecode

    For reasons that are not clear to me, the pytest4 check phase produces a
    lot of non-deterministic bytecode files. This PR turns off bytecode
    generation and disables a test that force enables bytecode generation.
    d-xo committed Oct 27, 2019
    Copy the full SHA
    5cd5661 View commit details

Commits on Apr 22, 2020

  1. Merge pull request #72091 from xwvvvvwx/reproducible-pytest4

    python3Packages.pytest4: deterministic bytecode
    domenkozar authored Apr 22, 2020
    Copy the full SHA
    a63762a View commit details
Showing with 8 additions and 6 deletions.
  1. +8 −6 pkgs/development/python-modules/pytest/4.nix
14 changes: 8 additions & 6 deletions pkgs/development/python-modules/pytest/4.nix
Original file line number Diff line number Diff line change
@@ -6,11 +6,6 @@ buildPythonPackage rec {
version = "4.6.8";
pname = "pytest";

preCheck = ''
# don't test bash builtins
rm testing/test_argcomplete.py
'';

src = fetchPypi {
inherit pname version;
sha256 = "6192875be8af57b694b7c4904e909680102befcb99e610ef3d9f786952f795aa";
@@ -25,7 +20,14 @@ buildPythonPackage rec {
doCheck = !isPyPy; # https://github.com/pytest-dev/pytest/issues/3460
checkPhase = ''
runHook preCheck
$out/bin/py.test -x testing/ -k "not test_collect_pyargs_with_testpaths"
# don't test bash builtins
rm testing/test_argcomplete.py
# determinism - this test writes non deterministic bytecode
rm -rf testing/test_assertrewrite.py
PYTHONDONTWRITEBYTECODE=1 $out/bin/py.test -x testing/ -k "not test_collect_pyargs_with_testpaths"
runHook postCheck
'';