Python on Nix tests #85793
Merged
Python on Nix tests #85793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was disabled because it did not function yet, however, apparently it does with 3.8.
because the package that is used as part of the test does not support older versions.
|
what does venv get us when we already have PYTHONPATH to specific packages? |
|
I don't understand what you mean. These tests are to ensure |
|
oh, for some reason I thought we were using venv to test packages, not a test to validate venv's functionality |
jonringer
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-85793]$ nix-build ./nixpkgs/ -A python38.tests.nixenv-venv
these derivations will be built:
/nix/store/zqcgfwj2x21yc3yn5x2cplhd7n746i2h-python3-3.8.2-env.drv
/nix/store/msicpycvg075am99zl2yksqp1ykk7d15-python3-3.8.2-venv.drv
/nix/store/2z9bp5hnscznywiplca9bknwpijgpql7-python3-3.8.2-tests-nixenv-venv.drv
building '/nix/store/zqcgfwj2x21yc3yn5x2cplhd7n746i2h-python3-3.8.2-env.drv'...
created 4 symlinks in user environment
building '/nix/store/msicpycvg075am99zl2yksqp1ykk7d15-python3-3.8.2-venv.drv'...
building '/nix/store/2z9bp5hnscznywiplca9bknwpijgpql7-python3-3.8.2-tests-nixenv-venv.drv'...
test_base_prefix (test_python.TestCasePython) ... ok
test_interpreter (test_python.TestCasePython) ... ok
test_prefix (test_python.TestCasePython) ... ok
test_python_version (test_python.TestCasePython) ... ok
test_site_prefix (test_python.TestCasePython) ... ok
----------------------------------------------------------------------
Ran 5 tests in 0.000s
OK
/nix/store/vgk3dzw6smq6w722d5iaapmirwdchy1f-python3-3.8.2-tests-nixenv-venv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)