Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zulip: 4.0.0 -> 5.0.0 #85770

Merged
merged 1 commit into from Apr 26, 2020
Merged

zulip: 4.0.0 -> 5.0.0 #85770

merged 1 commit into from Apr 26, 2020

Conversation

alevy
Copy link
Contributor

@alevy alevy commented Apr 22, 2020 •
edited

Motivation for this change

Zulip 5.0 fixes multiple security issues. See:
https://blog.zulip.org/2020/04/01/zulip-desktop-5-0-0-security-release/

(cherry picked from commit 1586f28)
Reason: Zulip < 5.0.0 no longer works with the Zulip server---if you run
it with an up to date Zulip server you get an error message requesting
you upgrade to 5.0 and the app will otherwise not be functional.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alevy
zulip: 4.0.0 -> 5.0.0
81dbd2f 
Zulip 5.0 fixes multiple security issues. See:
https://blog.zulip.org/2020/04/01/zulip-desktop-5-0-0-security-release/

(cherry picked from commit 1586f28)
Reason: Zulip < 5.0.0 no longer works with the Zulip server---if you run
it with an up to date Zulip server you get an error message requesting
you upgrade to 5.0 and the app will otherwise not be functional.
@ofborg ofborg bot requested a review from jonafato April 22, 2020 13:08
@alevy
Copy link
Contributor Author

alevy commented Apr 22, 2020

Closure size before:

$ nix path-info -S /nix/store/d2ifz858d5459rpvlk2m9qrldc5qsdhn-zulip-4.0.0
/nix/store/d2ifz858d5459rpvlk2m9qrldc5qsdhn-zulip-4.0.0  2943080672

Closure size after:

$ nix path-info -S /nix/store/7vfz0i3k5nnh1gcqsi1gc2s58is1w5x8-zulip-5.0.0
/nix/store/7vfz0i3k5nnh1gcqsi1gc2s58is1w5x8-zulip-5.0.0  2996521264

@CloudArtAdmins
Copy link
Contributor

Built, the GUI seems to work.
Not sure if it the program or our version of the package, but on closing errors were returned about electron.

@alevy
Copy link
Contributor Author

alevy commented Apr 22, 2020

Not sure if it the program or our version of the package

AFAICT this is the program, and there have been electron errors for me for previous versions as well.

@zimbatm zimbatm merged commit c0c339b into NixOS:release-20.03 Apr 26, 2020
@alevy alevy deleted the zulip-backport-20.03 branch April 27, 2020 17:25
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@alevy @stigok
zulip: 4.0.0 -> 5.0.0 (NixOS#85770)
e50ef20 
Zulip 5.0 fixes multiple security issues. See:
https://blog.zulip.org/2020/04/01/zulip-desktop-5-0-0-security-release/

(cherry picked from commit 1586f28)
Reason: Zulip < 5.0.0 no longer works with the Zulip server---if you run
it with an up to date Zulip server you get an error message requesting
you upgrade to 5.0 and the app will otherwise not be functional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonafato jonafato Awaiting requested review from jonafato

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alevy @CloudArtAdmins @zimbatm