Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

journald service docs: Add helpful comments about the journal getting full #85735

Merged
merged 1 commit into from Apr 23, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Apr 22, 2020

Motivation for this change

Follow-up to #85692: Explain that, and how, the journal can get full very quickly when applications spam.

Computation:

10000 {message burst limit} * 2 {30s slots per minute} * 60 {minutes per hour} * 100 {Bytes per log line} / 1e9 {B/GB}
= 0.12 {GB/hour}

At 4 GB limit that's 33 hours of logging == 1 day and a bit.
Things done

Copy link
Member

@calbrecht calbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By all means i am not a native english speaker, nor do i think my english is better... I just used https://www.reverso.net/spell-checker/english-spelling-grammar/ right now and it suggests changes, i don't mean to criticize your efforts :) Thanks for the contribution.

@nh2
Copy link
Contributor Author

nh2 commented Apr 22, 2020

By all means i am not a native english speaker, nor do i think my english is better... I just used https://www.reverso.net/spell-checker/english-spelling-grammar/ right now and it suggests changes, i don't mean to criticize your efforts :) Thanks for the contribution.

@calbrecht No offense taken!

I cannot find useful suggestions with that tool though, it seems to think that journald is a misspelling of journal (which is not the case), and I'm also not convinced that at a full burst rate is a more correct way to say at full burst rate.

Copy link
Member

@calbrecht calbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nh2, about the second one, i am unsure as well :) Anyway, i do think this is valuable information. Thanks :)

@@ -604,6 +607,19 @@ in
interval) that is applied to all messages generated on the system.
This rate limiting is applied per-service, so that two services
which log do not interfere with each other's limit.

Note that the effective rate limit is multiplied with a factor derived
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it tells me "by a factor"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I hadn't grammar-checked that because I copy-pased that entire sentence straight from the journald.conf man page, which also has that incorrect grammar:

https://www.freedesktop.org/software/systemd/man/journald.conf.html

I agree that multiplied by is correct here, and will update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstreaming at systemd/systemd#15552.

@nh2 nh2 force-pushed the journald-storage-limit-logs branch from 4546d83 to 811411d Compare April 23, 2020 00:25
@flokli flokli merged commit 25605d2 into NixOS:master Apr 23, 2020
@flokli
Copy link
Contributor

flokli commented Apr 23, 2020

Cherry-picked to 20.03 in 811411d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants