New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
journald service docs: Add helpful comments about the journal getting full #85735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By all means i am not a native english speaker, nor do i think my english is better... I just used https://www.reverso.net/spell-checker/english-spelling-grammar/ right now and it suggests changes, i don't mean to criticize your efforts :) Thanks for the contribution.
@calbrecht No offense taken! I cannot find useful suggestions with that tool though, it seems to think that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nh2, about the second one, i am unsure as well :) Anyway, i do think this is valuable information. Thanks :)
@@ -604,6 +607,19 @@ in | |||
interval) that is applied to all messages generated on the system. | |||
This rate limiting is applied per-service, so that two services | |||
which log do not interfere with each other's limit. | |||
|
|||
Note that the effective rate limit is multiplied with a factor derived |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it tells me "by a factor"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I hadn't grammar-checked that because I copy-pased that entire sentence straight from the journald.conf
man page, which also has that incorrect grammar:
https://www.freedesktop.org/software/systemd/man/journald.conf.html
I agree that multiplied by
is correct here, and will update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstreaming at systemd/systemd#15552.
4546d83
to
811411d
Compare
Cherry-picked to 20.03 in 811411d. |
Motivation for this change
Follow-up to #85692: Explain that, and how, the journal can get full very quickly when applications spam.
Computation:
Things done