Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fverb: init at unstable-2020-06-09 #85776

Merged
merged 1 commit into from Jun 24, 2020
Merged

fverb: init at unstable-2020-06-09 #85776

merged 1 commit into from Jun 24, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Apr 22, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave notes about why unstable. Maybe change line in all-packages.nix

@GrahamcOfBorg build fverb

pkgs/applications/audio/fverb/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/fverb/default.nix Show resolved Hide resolved
pkgs/applications/audio/fverb/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/fverb/default.nix Outdated Show resolved Hide resolved
@magnetophon
Copy link
Member Author

@drewrisinger Thanks, all done.

drewrisinger
drewrisinger suggested changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the repo, and it looks fairly out-of-date/inactive. Makes me semi wary of packaging this.

Also, in terms of naming, there seems to be some precedent for naming LV2 plugins as name-lv2 or name.lv2. I really don't have much familiarity with this ecosystem, just an observation. See e.g. https://github.com/NixOS/nixpkgs/blob/84cf00f98031e93f389f1eb93c4a7374a33cc0a9/pkgs/applications/audio/ir.lv2/default.nix

It does build locally via nixpkgs-review pr 85776. Untested

https://github.com/NixOS/nixpkgs/pull/85776
1 package built:
fverb

@magnetophon
Copy link
Member Author

The repo is pretty new, yes, but not inactive or out of date.
None of that matters though, since an audio effect just needs to do 2 things: sound good and be reliable.
The sound is subjective (I think it sounds gorgeous), but the language it is written in (faust) makes the reliability a given.

Therefore I would argue: this package is mature, and should be included.

As for the name: I named the package ir.lv2 because upstream is called that.
Similar for other lv2's.

@drewrisinger
Copy link
Contributor

The repo is pretty new, yes, but not inactive or out of date.

You are correct. My mistake, moving too quick & making assumptions.

Ack. Changing to approved.
@GrahamcOfBorg build fverb

@drewrisinger drewrisinger self-requested a review April 29, 2020 14:48
@magnetophon magnetophon mentioned this pull request Jun 5, 2020
Draft
10 tasks
@magnetophon magnetophon changed the title fverb: init at unstable-2020-04-04 fverb: init at unstable-2020-09-06 Jun 9, 2020
@drewrisinger
Copy link
Contributor

Convention is to write dates as YYYY-MM-DD, b/c then versions are strictly monotonically increasing left to right. Please change the commit message/title.

drewrisinger
drewrisinger reviewed Jun 11, 2020
View reviewed changes
pkgs/applications/audio/fverb/default.nix Outdated
Comment on lines 4 to 6
}:
stdenv.mkDerivation rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking, but...

Suggested change
}:
stdenv.mkDerivation rec {
}:
stdenv.mkDerivation rec {

@doronbehar
Copy link
Contributor

Convention is to write dates as YYYY-MM-DD

Nice catch!

@magnetophon magnetophon changed the title fverb: init at unstable-2020-09-06 fverb: init at unstable-2020-06-09 Jun 11, 2020
@magnetophon
Copy link
Member Author

@drewrisinger drew All done!
@doronbehar lol!

If you are interested, I have a bunch of other, mostly audio related, PR's open! ;)

drewrisinger
drewrisinger approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Builds via OfBorg (aarch64, amd64)

jtojnar
jtojnar reviewed Jun 12, 2020
View reviewed changes
pkgs/applications/audio/fverb/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/fverb/default.nix Show resolved Hide resolved
pkgs/applications/audio/fverb/default.nix Show resolved Hide resolved
pkgs/applications/audio/fverb/default.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/172

@jtojnar jtojnar merged commit 0512c8f into NixOS:master Jun 24, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jun 24, 2020

Thanks.

@magnetophon
Copy link
Member Author

Thank you!

@magnetophon magnetophon deleted the fvrb branch June 24, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@doronbehar doronbehar doronbehar left review comments

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@magnetophon @drewrisinger @doronbehar @nixos-discourse @jtojnar