Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hakyll: relax upper bound on warp #85753

Merged
merged 1 commit into from Apr 23, 2020
Merged

haskellPackages.hakyll: relax upper bound on warp #85753

merged 1 commit into from Apr 23, 2020

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Apr 22, 2020 •
edited

Motivation for this change

See #85670.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vaibhavsagar vaibhavsagar mentioned this pull request Apr 22, 2020
Closed
@cdepillabout
Copy link
Member

@GrahamcOfBorg build

@cdepillabout
Copy link
Member

@worldofpeace I may be incorrect about this, but the 20.03 branch that fixes should be merged into is release-20.03, not nixos-20.03, right?

@worldofpeace
Copy link
Contributor

@worldofpeace I may be incorrect about this, but the 20.03 branch that fixes should be merged into is release-20.03, not nixos-20.03, right?

nixos-20.03 is the nixos channel. so yes always release-20.03 as per the backporting docs.

@worldofpeace worldofpeace changed the base branch from nixos-20.03 to release-20.03 April 22, 2020 19:30
@cdepillabout
Copy link
Member

@worldofpeace Thanks for clearing this up!

@vaibhavsagar Thanks for fixing hakyll. Looks good so I'm merging in!

@cdepillabout cdepillabout merged commit 0787c45 into NixOS:release-20.03 Apr 23, 2020
@vaibhavsagar vaibhavsagar deleted the hakyll-upper-warp branch April 23, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @cdepillabout @worldofpeace