Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.asn1-types: backport 0.3.3 -> 0.3.4 #85754

Closed
wants to merge 1 commit into from
Closed

haskellPackages.asn1-types: backport 0.3.3 -> 0.3.4 #85754

wants to merge 1 commit into from

Conversation

schmittlauch
Copy link
Member

@schmittlauch schmittlauch commented Apr 22, 2020 •
edited

Motivation for this change

asn1-types fixes a runtime crash when parsing Unicode text

Things done
  • add a version override to configuration-stack2hackage.yaml
  • edited the hackage-packages.nix file by hand as regenerating it from the previously-used all-cabal-hashes revision did not include the new asn1-types revision yet.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

cdepillabout commented Apr 22, 2020 •
edited

@schmittlauch Hmm, I couldn't find anything upstream that talked about what the 0.3.4 release fixes. Upstream unfortunately doesn't provide a changelog.

However, there is vincenthz/hs-asn1#35. If this is the issue that is fixed, could you include a link to this as well?

Other than that, I think this fix looks good.

Although, it does cause quite a lot of rebuilds.

What are the rules about when something needs to be merged into staging-20.03? @jonringer @worldofpeace

Is staging-20.03 even a thing? I actually don't know that much about how the release-* branches work.

@Mic92
Copy link
Member

Mic92 commented Apr 22, 2020 •
edited

staging-20.03 just works like staging. Just add it there. We usually only pull security updates directly into release branches.

@schmittlauch
Copy link
Member Author

okay, I'll rebase it on top of staging-20.03

@schmittlauch schmittlauch mentioned this pull request Apr 22, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmittlauch @cdepillabout @Mic92