Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] ninja: fix 404'ing patch #85742

Merged
merged 1 commit into from Apr 22, 2020
Merged

[20.03] ninja: fix 404'ing patch #85742

merged 1 commit into from Apr 22, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Apr 22, 2020 •
edited

Kyndig on IRC noticed that building ninja from source would fail due
to this patch 404'ing (because the repo appears to no longer exist).
Fetch from upstream instead.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @worldofpeace

Verified nothing changed with nixpkgs-review rev HEAD --branch release-20.03.

Fixes #85741.

@cole-h
ninja: fix 404'ing patch
91d4e9a 
Kyndig on IRC noticed that building `ninja` from source would fail due
to a patch 404'ing (because the repo appears to no longer exist). Fetch
from upstream instead.
worldofpeace
worldofpeace approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be perfect. Just waiting for eval.

@worldofpeace worldofpeace merged commit 63284ec into NixOS:release-20.03 Apr 22, 2020
@cole-h cole-h deleted the fix-ninja-patch branch April 22, 2020 01:38
veprbl pushed a commit that referenced this pull request Apr 26, 2020
@cole-h @veprbl
ninja: fix 404'ing patch
4a0df0c 
Kyndig on IRC noticed that building `ninja` from source would fail due
to a patch 404'ing (because the repo appears to no longer exist). Fetch
from upstream instead.

(cherry picked from commit 91d4e9a)
cc #85742
veprbl pushed a commit that referenced this pull request Apr 26, 2020
@cole-h @veprbl
ninja: fix 404'ing patch
27aaaa5 
Kyndig on IRC noticed that building `ninja` from source would fail due
to a patch 404'ing (because the repo appears to no longer exist). Fetch
from upstream instead.

(cherry picked from commit 91d4e9a)
cc #85742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @worldofpeace