Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nushell: 0.12.0 -> 0.13.0 #85737

Merged
merged 1 commit into from May 1, 2020
Merged

nushell: 0.12.0 -> 0.13.0 #85737

merged 1 commit into from May 1, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 22, 2020

Motivation for this change

Release notes: https://www.nushell.sh/blog/2020/04/21/nushell_0_13_0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Br1ght0ne April 22, 2020 00:57
@teto
Copy link
Member

teto commented Apr 22, 2020

nixpkgs-review failed for me

test shell::pipeline::doesnt_break_on_utf8 ... ok
test shell::pipeline::commands::internal::tilde_expansion::as_home_directory_when_passed_as_argument_and_begins_with_tilde ... ok
test shell::pipeline::commands::internal::takes_rows_of_nu_value_strings_and_pipes_it_to_stdin_of_external ... FAILED

failures:

---- shell::pipeline::commands::internal::takes_rows_of_nu_value_strings_and_pipes_it_to_stdin_of_external stdout ----
=== stderr

thread 'shell::pipeline::commands::internal::takes_rows_of_nu_value_strings_and_pipes_it_to_stdin_of_external' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"AndKitKat"`', tests/shell/pipeline/commands/internal.rs:31:9


failures:
    shell::pipeline::commands::internal::takes_rows_of_nu_value_strings_and_pipes_it_to_stdin_of_external

@Ma27
Copy link
Member

Ma27 commented Apr 29, 2020

@teto on which env did you test? ofborg seems to pass and I managed to build it as well locally :)

@teto
Copy link
Member

teto commented Apr 29, 2020

nixos-unstable on a slow machine. Might be a flaky test, Because my machine is so slow, I don't want to retry xD @filalex77 did it fail for you too (seeing yout thumb up)

@FRidh FRidh merged commit 861a342 into NixOS:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cust0dian-old cust0dian-old cust0dian-old approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @teto @Ma27 @cust0dian-old @FRidh