Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: version bumps #85715

Merged
merged 12 commits into from Apr 22, 2020
Merged

linux: version bumps #85715

merged 12 commits into from Apr 22, 2020

Conversation

kraem
Copy link
Member

@kraem kraem commented Apr 21, 2020 •
edited

Motivation for this change

Versions bumps.
5.6.5 -> 5.6.6
5.5.18 -> 5.5.19
5.4.33 -> 5.4.34
4.19.116 -> 4.19.117

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kraem
Copy link
Member Author

kraem commented Apr 22, 2020 •
edited

Ping @emilazy @NeQuissimus, the patches came in and the tests passed :)

emilazy
emilazy approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeQuissimus
Copy link
Member

@kraem Can you make a PR against release-20.03 as well, please?

@kraem
Copy link
Member Author

kraem commented Apr 22, 2020

Sure! I forgot to answer you yesterday. I had to research how the backports were made to the stable branches (what policies there are etc). I'll fix a PR for 20.03!

@NeQuissimus NeQuissimus merged commit 767b917 into NixOS:master Apr 22, 2020
@kraem kraem deleted the kraem/linux-5.6.6 branch May 2, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kraem @NeQuissimus @emilazy