Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build airsonic from source and allow patches #85714

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ToxicFrog
Copy link
Contributor

Motivation for this change

The current package simply installs the Airsonic binary. This change (a) makes it build from source instead, so that patches can be applied, and (b) adds a patch that inverts the (hard-coded) podcast sort order so that "play all" on a podcast plays them in chronological order rather than reverse chronological.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ToxicFrog ToxicFrog changed the title Airsonic Build airsonic from source and allow patches Apr 21, 2020
@delroth
Copy link
Contributor

delroth commented Apr 22, 2020

+1 to building from source. However I think that patch would be a better fit for your own nixpkgs overlay, or contributed upstream directly.

@ToxicFrog
Copy link
Contributor Author

Ok, it looks like you can't use mavenix in nixpkgs, or at least you have to use it in a completely different fashion -- pre-download it and include it in the .nix files for that package?

@ToxicFrog
Copy link
Contributor Author

Patch excised and moved to my personal overlays while I work on the additional infrastructure needed to get it upstream-ready.
Airsonic build updated to 10.6.2 to match nixpkgs master, and rebased.

@ToxicFrog
Copy link
Contributor Author

Rebased against unstable to resolve merge conflicts in maintainers file.

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@wegank wegank marked this pull request as draft March 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants