Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: vim-airline-clock init at 2018-05-08 #91567

Merged
merged 1 commit into from Oct 29, 2020
Merged

vimPlugins: vim-airline-clock init at 2018-05-08 #91567

merged 1 commit into from Oct 29, 2020

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Jun 26, 2020 •
edited

Motivation for this change

vim-airline-clock

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Vonfry Vonfry requested a review from jonringer as a code owner June 26, 2020 08:21
@ofborg ofborg bot requested a review from jorsn June 26, 2020 08:38
@Vonfry Vonfry changed the title vimPlugins: vim-airline-clock init vimPlugins: vim-airline-clock init at 2018-05-08 Jun 26, 2020
@Vonfry Vonfry force-pushed the vimPlugins/vim-airline-clock branch from 8e52830 to 118a44d Compare June 26, 2020 23:53
@Vonfry Vonfry force-pushed the vimPlugins/vim-airline-clock branch from 118a44d to 77495dc Compare July 5, 2020 01:39
@Vonfry Vonfry force-pushed the vimPlugins/vim-airline-clock branch from 77495dc to 5e20a03 Compare July 5, 2020 01:43
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/219

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/185

@evenbrenden evenbrenden self-requested a review August 3, 2020 22:06
evenbrenden
evenbrenden approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@evenbrenden evenbrenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on NixOS (nixos-20.09pre231796.22a81aa5fc1) via home-manager (home-manager-2020-03-17).

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/267

@kevincox kevincox merged commit 0d7a65b into NixOS:master Oct 29, 2020
@Vonfry Vonfry deleted the vimPlugins/vim-airline-clock branch December 3, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenbrenden evenbrenden evenbrenden approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vonfry @nixos-discourse @evenbrenden @kevincox