Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: vim-ragtag init at 2020-01-26 #91558

Merged
merged 1 commit into from Aug 15, 2020
Merged

vimPlugins: vim-ragtag init at 2020-01-26 #91558

merged 1 commit into from Aug 15, 2020

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Jun 26, 2020 •
edited

Motivation for this change

Add a new vim plugin. vim-ragtag

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Vonfry Vonfry requested a review from jonringer as a code owner June 26, 2020 07:50
@Vonfry Vonfry changed the title vimPlugins.vim-ragtag: init vimPlugins: vim-ragtag init Jun 26, 2020
@ofborg ofborg bot requested a review from jorsn June 26, 2020 08:02
@jonringer
Copy link
Contributor

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

vimPlugins.vim-ragtag: init at 2020-01-26

@Vonfry Vonfry changed the title vimPlugins: vim-ragtag init vimPlugins: vim-ragtag init at 2020-01-26 Jun 26, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/219

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/185

jonringer
jonringer approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91558 1

1 package built: - vimPlugins.vim-ragtag

@jonringer jonringer merged commit 8397bb9 into NixOS:master Aug 15, 2020
@Vonfry Vonfry deleted the vimPlugins/ragtag branch October 6, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vonfry @jonringer @nixos-discourse