Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: vim-rails init at 2020-06-19 #91565

Closed
wants to merge 1 commit into from
Closed

vimPlugins: vim-rails init at 2020-06-19 #91565

wants to merge 1 commit into from

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Jun 26, 2020

Motivation for this change

A new vim plugin, vim-rails

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Vonfry Vonfry requested a review from jonringer as a code owner June 26, 2020 08:02
@ofborg ofborg bot requested a review from jorsn June 26, 2020 08:32
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/219

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/185

@Vonfry Vonfry closed this Aug 15, 2020
@jonringer
Copy link
Contributor

sorry I wasn't able to get around to this, if you want to re-open, I would be happy to review it

@Vonfry
Copy link
Member Author

Vonfry commented Aug 15, 2020

@jonringer Thanks, but this plugin has been pulled by others and it was merged.

@jonringer
Copy link
Contributor

ah, alright then.

@Vonfry Vonfry deleted the vimPlugins/vim-rails branch November 27, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vonfry @nixos-discourse @jonringer