Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: MatchTagAlways init at 2017-05-20 #91564

Merged
merged 1 commit into from Nov 25, 2020
Merged

vimPlugins: MatchTagAlways init at 2017-05-20 #91564

merged 1 commit into from Nov 25, 2020

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Jun 26, 2020 •
edited

Motivation for this change

A new vim plugin: match tag always

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Vonfry Vonfry requested a review from jonringer as a code owner June 26, 2020 07:59
@ofborg ofborg bot requested a review from jorsn June 26, 2020 08:24
@Vonfry Vonfry force-pushed the vimPlugins/MatchTagAlways branch from 6d1367a to c757cec Compare June 26, 2020 23:54
@Vonfry Vonfry force-pushed the vimPlugins/MatchTagAlways branch from c757cec to 544ff22 Compare July 5, 2020 01:47
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/219

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/185

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/267

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/353

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 91564 run on x86_64-linux 1

1 package built:
  • vimPlugins.MatchTagAlways

@SuperSandro2000 SuperSandro2000 merged commit 57692d5 into NixOS:master Nov 25, 2020
@Vonfry Vonfry deleted the vimPlugins/MatchTagAlways branch November 26, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vonfry @nixos-discourse @SuperSandro2000 @ryantm